Fixed version 3.8.1 from Google Play cannot find zim on SD card that are copied to app-specific directory.
#3582
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3582 +/- ##
==========================================
Coverage 48.93% 48.94%
Complexity 1087 1087
==========================================
Files 285 285
Lines 10495 10496 +1
Branches 1404 1404
==========================================
+ Hits 5136 5137 +1
Misses 4527 4527
Partials 832 832 ☔ View full report in Codecov by Sentry. |
|
@gouri-panda Looks good to you? |
|
@kelson42 I'm looking at the search issues that we're having. After that, I'll complete this 👍 |
| @@ -36,6 +36,14 @@ object StorageDeviceUtils { | |||
| add(environmentDevices(context)) | |||
| addAll(externalMountPointDevices()) | |||
| addAll(externalFilesDirsDevices(context, false)) | |||
There was a problem hiding this comment.
addAll(externalFilesDirsDevices(context, false))
@MohitMaliFtechiz Then we shouldn't need this anymore? right?
There was a problem hiding this comment.
@gouri-panda We need this because it scans for the device's main directory when we pass false into it.
private fun generalisePath(path: String, writable: Boolean) =
if (writable) path
else path.substringBefore("/Android/data/")
…t are copied to app-specific directory. * Scan the app-specific directory as well because we have limitations in scanning all directories on Android 11 and above in the Play Store variant. If a user copies the ZIM file to the app-specific directory on the SD card, the scanning of the app-specific directory on the SD card has not been added, resulting in the copied files not being displayed on the library screen. Therefore, we need to explicitly include the app-specific directory for scanning.
|
no time to wait more for a review |
Fixes #3579
We have limitations in scanning all directories on Android 11 and above in the Play Store variant. If a user copies the ZIM file to the app-specific directory on the SD card, the scanning of the app-specific directory on the SD card has not been added, resulting in the copied files not being displayed on the library screen. Therefore, we added the scanning of app-specific directory to fix the issue.