Fixed: The WiFi hotspot no longer starts automatically after granting notification permission in Android 13 and above. #3729
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3729 +/- ##
============================================
- Coverage 52.47% 51.82% -0.66%
+ Complexity 1259 1225 -34
============================================
Files 291 291
Lines 10957 10960 +3
Branches 1464 1465 +1
============================================
- Hits 5750 5680 -70
- Misses 4240 4316 +76
+ Partials 967 964 -3 ☔ View full report in Codecov by Sentry. |
… notification permission in Android 13 and above. * We implemented the `registerForActivityResult` method to handle notification permission, ensuring the hotspot starts seamlessly upon permission grant. * Improved the permission-asking scenario. Before it ask once for notification permission and at the second time it shows the custom dialog that shows why we need this permission. But we can ask permission twice in our application so we have improved the asking of permission. If the user denies this permission then we show the custom dialog with message why we need this permission.
|
@MohitMaliDeveloper I don't understand how it works smoothly now: last screencase show twice the notification popup (the very same one) and then the settings... how is that better? |
|
@kelson42 It shows the notification permission when the user clicks on the "START SERVER" button. and if the user denies the permission intentionally or by mistake, and again tries to start the hotspot via clicking on the "START SERVER" button, then the application again asks for notification permission(if not permanently denied), so the user has an extra chance to grant the permission without going into application settings, and if he again denies the permission then immediately shows the custom dialog with the message why we need this permission (as we were showing previously). So in this scenario user has an extra chance to rethink/grant the permission. |
Fixes #3728
registerForActivityResultmethod to handle notification permission, ensuring the hotspot starts seamlessly upon permission grant.HotspotNotStarting.mp4
HotspotNotAutomaticallyStartingFix.mp4
PermissionBefore.mp4
PermissionAfter.mp4