-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
Can you give me some example (queries) at hand? .. who is using hubspot? / thanks |
27628c9
to
d8d3a45
Compare
Digging up those links I found a couple of parameters I missed with a SE post to boot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charme / thanks a lot!
One nit I have; do you like to add the links from the comment:
https://knowledge.hubspot.com/settings/how-do-i-create-a-tracking-url
https://knowledge.hubspot.com/ads/ad-tracking-in-hubspot
https://knowledge.hubspot.com/ctas/calls-to-action-frequently-asked-questions
to the commit message? This will help later, when others want to maintain the regular expressions.
Once the comments above are addressed, it is ready to be merged. Also, while you are rewording the commit message, please rebase the branch on top of master. |
More information here: https://knowledge.hubspot.com/settings/how-do-i-create-a-tracking-url https://knowledge.hubspot.com/ads/ad-tracking-in-hubspot https://knowledge.hubspot.com/ctas/calls-to-action-frequently-asked-questions https://meta.stackexchange.com/questions/263392/what-are-these-very-long-parameters-in-so-careers-feedback-always-welcome-url
d8d3a45
to
2ca0aa4
Compare
Roger that! Just pushed |
@3nprob Thank you! |
What does this PR do?
Removes hubspot tracking parameters from result URLS