Skip to content
This repository has been archived by the owner on Sep 7, 2023. It is now read-only.

Remove hubsbpot tracking URL params #2723

Merged
merged 1 commit into from
Apr 5, 2021

Conversation

3nprob
Copy link

@3nprob 3nprob commented Apr 5, 2021

What does this PR do?

Removes hubspot tracking parameters from result URLS

@return42
Copy link
Contributor

return42 commented Apr 5, 2021

Can you give me some example (queries) at hand? .. who is using hubspot? / thanks

@3nprob
Copy link
Author

3nprob commented Apr 5, 2021

@3nprob 3nprob force-pushed the clean-hubspot-tracking-urls branch from 27628c9 to d8d3a45 Compare April 5, 2021 13:24
@3nprob
Copy link
Author

3nprob commented Apr 5, 2021

Digging up those links I found a couple of parameters I missed with a SE post to boot

https://meta.stackexchange.com/questions/263392/what-are-these-very-long-parameters-in-so-careers-feedback-always-welcome-url

return42
return42 previously approved these changes Apr 5, 2021
Copy link
Contributor

@return42 return42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charme / thanks a lot!

One nit I have; do you like to add the links from the comment:

https://knowledge.hubspot.com/settings/how-do-i-create-a-tracking-url
https://knowledge.hubspot.com/ads/ad-tracking-in-hubspot
https://knowledge.hubspot.com/ctas/calls-to-action-frequently-asked-questions

to the commit message? This will help later, when others want to maintain the regular expressions.

@kvch
Copy link
Member

kvch commented Apr 5, 2021

Once the comments above are addressed, it is ready to be merged. Also, while you are rewording the commit message, please rebase the branch on top of master.

@3nprob
Copy link
Author

3nprob commented Apr 5, 2021

Roger that! Just pushed

@kvch kvch merged commit 736d065 into searx:master Apr 5, 2021
@kvch
Copy link
Member

kvch commented Apr 5, 2021

@3nprob Thank you!

@3nprob 3nprob deleted the clean-hubspot-tracking-urls branch April 6, 2021 02:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants